Determine Spring Boot version on startup correctly when using Jigsaw #16182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Java 9, a package may return null for its implementation version even when the manifest attribute specifying the version is present in the jar from which the package was loaded. This commit updates SpringBootVersion to fall back to accessing the jar and its manifest attributes directly when the implementation version of its package is null. Closes spring-projectsgh-10233
spring-projects-issues
added
the
status: waiting-for-triage
Previously, the import selector wrongly assumed that we should not use constructor injection with Kotlin. Rather than looking up for the primary constructor, we retrieve available constructors on the Java counter-part. This commit applies the same logic as in the constructor parameter binder and checks for the primary constructor for Kotlin types. See spring-projectsgh-8762
This commit detects a Kotlin constructor so that it is not required to transmit the parameter names information to the Java side. See spring-projectsgh-8762
|
Thanks for the fix. Since this is just a cosmetic problem I'm tempted to target it to 2.2 rather the 2.1 (which #10233 was originally targeted to). |
philwebb
added
type: bug
Update the `BaseConfiguration` class in `ScheduledTasksEndpointTests` to be package private so that it can be enhanced by cglib. Prior to merge commit 361437f the class was a lite configuration so it didn't matter that it was a private class.
Closes spring-projectsgh-16219
* pr/16219: Polish
* pr/16104: Polish "Add default no-op method to SpringApplicationRunListener" Add default no-op method to SpringApplicationRunListener
* pr/16099: Polish "Order the search locations in javadoc by precedence order" Order the search locations in javadoc by precedence order
* pr/16250: Switch FaviconRequestHandler visibility to package private
|
@hsellik Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@hsellik Thank you for signing the Contributor License Agreement! |
|
@philwebb is there something I can do to get this merged or are 2.2 pull requests getting merged in a later point in time? I can make a new pull request, which is not on my master branch (sorry for that). |
|
@hsellik There's just a bit of a backlog at the moment as a lot of the team are away. There's no need for a new PR, we can just cherry-pick the commit. |
wilkinsona
added
type: enhancement
wilkinsona
pushed a commit
that referenced
this pull request
Apr 18, 2019
In Java 9, a package may return null for its implementation version even when the manifest attribute specifying the version is present in the jar from which the package was loaded. This commit updates SpringBootVersion to fall back to accessing the jar and its manifest attributes directly when the implementation version of its package is null. See gh-16182
wilkinsona
added a commit
that referenced
this pull request
Apr 18, 2019
|
Thanks very much for the PR, @hsellik. I've cherry-picked the change and merged it into master along with a polish commit. |
wilkinsona
added a commit
that referenced
this pull request
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Java 9, a package may return null for its implementation version
even when the manifest attribute specifying the version is present
in the jar from which the package was loaded.
This commit updates SpringBootVersion to fall back to
accessing the jar and its manifest attributes directly when the
implementation version of its package is null.
Closes gh-10233